Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Gas is not correctly estimated when Sending ETH to a Contract using a Deeplink #6405

Closed
seaona opened this issue May 16, 2023 · 6 comments
Labels
area-gas needs-estimate Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking stale Issues that have not had activity in the last 90 days team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented May 16, 2023

Describe the bug
Whenever I am sending ETH to a contract address using a deeplink, I can see how the gas is not correctly calculated, resulting in the errror intrinsic gas too low if I try to Send the transaction.

Screenshots

send-eth-contract-deeplink.mp4

To Reproduce
Steps to reproduce the behavior

  1. Select Sepolia network
  2. Click on Scan

image

  1. See gas is not correctly calculated
  2. Click Send
  3. See intrinsic gas too low error

Expected behavior
Gas should be correctly calculated.

Smartphone (please complete the following information):

  • Device: Pixel 6
  • OS: Android
  • App Version: it was working on v6.5.0 and not working on v6.6.0 onwards

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@seaona seaona added type-bug Something isn't working team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels May 16, 2023
@bschorchit bschorchit added area-gas Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking labels Jun 2, 2023
@bschorchit
Copy link

I was not able to reproduce this on ios v6.3.0 so this might have been introduced at a later release or is android specific.

@seaona
Copy link
Contributor Author

seaona commented Jun 6, 2023

I am able to reproduce this on iOS v7.0.0 and also on Android v6.6.0 and v6.7.0 . I think that the issues about Intrinsic Gas were fixed at some point in time and later on re-introduced in 6.6.0

@chentschel
Copy link

I'm having the same issue with IOS v7.0.1. Looks like gas or gasLimit params are ignored in the links.

This is some example link i'm testing.

ethereum:0xdac17f958d2ee523a2206206994597c13d831ec7@1/transfer?address=0x69530F68541a5583F5B3D1dB1920b7523c55E77F&uint256=2.724e5&gas=75000

@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Aug 24, 2023
@bschorchit bschorchit added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead and removed team-confirmations-planning (only for internal use within Confirmations team) labels Sep 27, 2023
@bschorchit
Copy link

I'm able to reproduce this on ios v.7.7

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Jan 16, 2024
Copy link
Contributor

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-gas needs-estimate Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking stale Issues that have not had activity in the last 90 days team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants
@chentschel @bschorchit @seaona @hilvmason and others