Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated SheetBottom component with BottomSheet from the component-library #7658

Open
georgewrmarshall opened this issue Nov 1, 2023 · 0 comments
Labels
good first issue Good for newcomers INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-design-system All issues relating to design system in Mobile

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Nov 1, 2023

Description

Currently, mobile is using an outdated SheetBottom component, which needs to be replaced with the new BottomSheet component.

This is a massive undertaking by itself and assigning to a single contributor and creating a single PR would be too large. Smaller PRs can be submitted against this issue from multiple contributors to ensure easier review and gradual improvements.

Technical Details

  • Replace instances of SheetBottom component (app/component-library/components/Sheet/SheetBottom/SheetBottom.tsx) with BottomSheet component (app/component-library/components/BottomSheets/BottomSheet/BottomSheet.tsx)
  • Component APIs are slightly different so ensure all props have been migrated appropriately

Acceptance Criteria

  • Instances of SheetBottom component are completely replaced with the new BottomSheet component
  • The component APIs are updated to reflect the changes in the new SheetBottom component and there is no functional changes or visual regression
  • Each Pull Request (PR) should include no more than 3 files
  • PR descriptions must adhere to the designated template, ensuring that all relevant sections are completed including before and after screenshots of UI.
  • The code changes should pass Jest tests, e2e tests, linting, and Storybook without any errors.

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running mobile locally, have knowledge of React Native, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in mobile

@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Mobile good first issue Good for newcomers labels Nov 1, 2023
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

No branches or pull requests

2 participants