Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated MaterialCommunityIcon component with Icon from the component-library #8113

Open
brianacnguyen opened this issue Dec 15, 2023 · 0 comments
Labels
good first issue Good for newcomers INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-design-system All issues relating to design system in Mobile

Comments

@brianacnguyen
Copy link
Contributor

brianacnguyen commented Dec 15, 2023

Description

Currently, mobile is using an outdated MaterialCommunityIcon component, which needs to be replaced with the new Icon component.

This is a massive undertaking by itself and assigning to a single contributor and creating a single PR would be too large. Smaller PRs can be submitted against this issue from multiple contributors to ensure easier review and gradual improvements.

Technical Details

  • Replace instances of MaterialCommunityIcon component with Icon component (app/component-library/components/Icons/Icon/Icon.tsx)
  • Component APIs are slightly different so ensure all props have been migrated appropriately

Acceptance Criteria

  • Instances of MaterialCommunityIcon component are completely replaced with the new Icon component
  • The component APIs are updated to reflect the changes in the new Icon component and there is no functional changes or visual regression
  • Each Pull Request (PR) should include no more than 3 files
  • PR descriptions must adhere to the designated template, ensuring that all relevant sections are completed including before and after screenshots of UI.
  • The code changes should pass Jest tests, e2e tests, linting, and Storybook without any errors.

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running mobile locally, have knowledge of React Native, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in mobile

@brianacnguyen brianacnguyen added good first issue Good for newcomers INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-design-system All issues relating to design system in Mobile labels Dec 15, 2023
@brianacnguyen brianacnguyen changed the title Copy of Replace deprecated AntDesignIcon component with Icon from the component-library Replace deprecated MaterialCommunityIcon component with Icon from the component-library Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

No branches or pull requests

1 participant