Bump @metamask/key-tree version
#1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1114 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 132 132
Lines 4339 4339
Branches 738 738
=======================================
Hits 4129 4129
Misses 210 210 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
packages/rpc-methods/package.json
Outdated
| @@ -71,5 +71,11 @@ | |||
| "publishConfig": { | |||
| "access": "public", | |||
| "registry": "https://registry.npmjs.org/" | |||
| }, | |||
| "lavamoat": { | |||
| "allowScripts": { | |||
There was a problem hiding this comment.
Any idea why this was added now?
There was a problem hiding this comment.
no... not sure. I was prompted to run the allow-scripts script and did so and it created that diff. But I just removed it and reran the script and it was not added... Not sure what that's about.
There was a problem hiding this comment.
Removed the allowScript configuration here: 90c5b47
adonesky1
force-pushed
the
bump-keytree-version
branch
from
10412e8
to
90c5b47
Compare
Mrtenz
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in update to
@metamask/key-treein which BIP-39 implementation is updated from@scure/bip39to MetaMask fork version@metamask/scure-bip39. The@metamask/scure-bip39fork accepts secret recovery phrases inUint8Arrayformat making it possible to use more secure patterns of passing secret recovery phrases around. This change is non-breaking however, as the mnemonicToSeed function used in this package still accepts secret recovery phrases in string format.Even before Snaps switches to passing SRPs as Uint8Arrays this change will be useful by unifying the extension on one BIP-39 implementation reducing redundant code.