We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet_enable
wallet_enable should be removed. We can add something like it back later if we think it's a good idea.
wallet_enable is designed to be a one-stop shop for dapp developers. It lets you:
eth_accounts
Currently, it can partially succeed/fail, which is why the result object includes an errors property:
errors
https://github.com/MetaMask/snaps-monorepo/blob/15212ab511e22f7b85c3c032a96fdf40f54dc12d/packages/rpc-methods/src/permitted/enable.ts#L24-L29
This method is something of an abominable mishmash. We should consider whether it should exist at all.
The text was updated successfully, but these errors were encountered:
wallet_installSnaps
wallet_requestSnaps
FrederikBolding
Successfully merging a pull request may close this issue.
wallet_enable
should be removed. We can add something like it back later if we think it's a good idea.Original Issue Content
wallet_enable
is designed to be a one-stop shop for dapp developers. It lets you:eth_accounts
, which gets its own property on the result object.Currently, it can partially succeed/fail, which is why the result object includes an
errors
property:https://github.com/MetaMask/snaps-monorepo/blob/15212ab511e22f7b85c3c032a96fdf40f54dc12d/packages/rpc-methods/src/permitted/enable.ts#L24-L29
This method is something of an abominable mishmash. We should consider whether it should exist at all.
The text was updated successfully, but these errors were encountered: