Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wallet_enable #894

Closed
rekmarks opened this issue Oct 31, 2022 · 0 comments · Fixed by #909
Closed

Remove wallet_enable #894

rekmarks opened this issue Oct 31, 2022 · 0 comments · Fixed by #909
Assignees

Comments

@rekmarks
Copy link
Member

rekmarks commented Oct 31, 2022

wallet_enable should be removed. We can add something like it back later if we think it's a good idea.

Original Issue Content

wallet_enable is designed to be a one-stop shop for dapp developers. It lets you:

  • Request arbitrary permissions
    • Including eth_accounts, which gets its own property on the result object.
  • Install / update snaps

Currently, it can partially succeed/fail, which is why the result object includes an errors property:

https://github.com/MetaMask/snaps-monorepo/blob/15212ab511e22f7b85c3c032a96fdf40f54dc12d/packages/rpc-methods/src/permitted/enable.ts#L24-L29

This method is something of an abominable mishmash. We should consider whether it should exist at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants