Update/add cycle bureau position #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott062
requested review from
mjoyce91,
elizabeth-jimenez and
SidelineCory24
|
Running tests locally - will update |
mjoyce91
reviewed
Oct 20, 2020
| 'Tour of duty': getResult(pos, 'post.tour_of_duty', NO_TOUR_OF_DUTY), | ||
| 'Language': language, | ||
| 'Post differential | Danger Pay': getDifferentials(pos), | ||
| 'Cycle': getResult(pos, 'latest_bidcycle.name', 'None Listed'), |
There was a problem hiding this comment.
Let's call it "Bid cycle" since that's what we use on the regular results cards
There was a problem hiding this comment.
So I was going to create a separate story for this, but we need to do an audit of all the filter/card names b/c sometimes its Bid Cycle or Bid cycle.
There was a problem hiding this comment.
There are some places we use sentence casing and some we use title casing. I forget the exact rules on why/when we use each
mjoyce91
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: MetaPhase-Consulting/State-TalentMAP-API#434