Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold Position Manager Header Titles TM-2028 #1191

Merged
merged 8 commits into from
Oct 23, 2020

Conversation

SidelineCory24
Copy link

This makes the titles match "Last Updated" as the ticket request but does not make use of font-weight: bold.

Also, the ticket says to make the "Bid Count" text smaller. What should it be decreased to? 16px is the standard size for it on cards.

@SidelineCory24 SidelineCory24 added the WIP Work in progress label Oct 16, 2020
@SidelineCory24 SidelineCory24 changed the title changed color and increased font-size changed color and increased font-size TM-2028 Oct 16, 2020
@SidelineCory24 SidelineCory24 added do not merge and removed WIP Work in progress labels Oct 21, 2020
@elizabeth-jimenez
Copy link

elizabeth-jimenez commented Oct 21, 2020

This makes the titles match "Last Updated" as the ticket request but does not make use of font-weight: bold.

Also, the ticket says to make the "Bid Count" text smaller. What should it be decreased to? 16px is the standard size for it on cards.

It's ok that it doesn't use font-weight: bold to achieve the desired outcome; still looks good!
"What should it be decreased to?" 🤔 good question. I think 15px looks good! If everyone hates it, they'll let us know at the demo lol

@SidelineCory24 SidelineCory24 changed the title changed color and increased font-size TM-2028 Bold Position Manager Header Titles TM-2028 Oct 22, 2020
src/sass/_bureau.scss Outdated Show resolved Hide resolved
@elizabeth-jimenez
Copy link

🎉 Besides the changes in Position Details, this looks ready to go!

Copy link

@elizabeth-jimenez elizabeth-jimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍬 🍭 🍰 🍥 👍

@SidelineCory24 SidelineCory24 merged commit 3bcaba2 into dev Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants