export button functionality #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabeth-jimenez
requested review from
mjoyce91,
scott062 and
SidelineCory24
|
|
||
| export function availableBidderExport(cdo) { | ||
| return api() | ||
| .get(`${cdo ? '/cdo' : '/bureau'}/availablebidders/export/`) |
3 tasks
mjoyce91
reviewed
Feb 22, 2021
src/actions/availableBidders.js
Outdated
| return api() | ||
| .get(`${cdo ? '/cdo' : '/bureau'}/availablebidders/export/`) | ||
| .then((response) => { | ||
| downloadFromResponse(response, 'TalentMap_Available_Bidders_export'); |
There was a problem hiding this comment.
Could be good to add a timestamp to this so that if a user downloads multiple versions, they aren't just appended with (1), (2), (3), etc
There was a problem hiding this comment.
There was already a timestamp coming through from the BE, but I added one to the alt title, as well 🦜 also updated the alt name to be more similar to the BE one.
|
Can you take a look at the spinner shifting the content below it?
|
Got it 😫 |
mjoyce91
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dual Merge: BE PR
To help burndown chart, will update export in another PR with payload update.
WIP: waiting on AB payload updates.