Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup for cn/htf/snd flags #1431

Merged
merged 29 commits into from
Apr 16, 2021
Merged

setup for cn/htf/snd flags #1431

merged 29 commits into from
Apr 16, 2021

Conversation

SidelineCory24
Copy link

@SidelineCory24 SidelineCory24 commented Apr 6, 2021 •
edited

Setup/CSS for each flag

  • Critical Need is set to show on every position card (not hooked up yet to BE)

@SidelineCory24 SidelineCory24 added do not merge WIP Work in progress labels Apr 6, 2021
@SidelineCory24 SidelineCory24 changed the title initial setup for CN flag initial setup for CN/HTF/SND flags Apr 6, 2021
@SidelineCory24 SidelineCory24 changed the title initial setup for CN/HTF/SND flags initial setup for cn/htf/snd flags Apr 6, 2021
SidelineCory24
SidelineCory24 commented Apr 6, 2021
View reviewed changes
src/sass/_ribbon.scss Outdated Show resolved Hide resolved
@SidelineCory24 SidelineCory24 changed the title initial setup for cn/htf/snd flags setup for cn/htf/snd flags Apr 6, 2021
@SidelineCory24 SidelineCory24 removed the WIP Work in progress label Apr 12, 2021
@elizabeth-jimenez
Copy link

image
Still seeing the In BidList error

@elizabeth-jimenez
Copy link

image
I feel like this wasn't like this before 🤔

@elizabeth-jimenez
Copy link

image
I feel like this wasn't like this before 🤔

image
looks like a styling on HS is what moves CN over

@elizabeth-jimenez
Copy link

image
i think the solution here is to keep the box shadow stuff how it was and add the clip-path: polygon(9% 0, 100% 0, 91% 100%, 0 100%, 0 100%);

@SidelineCory24
Copy link
Author

Looks like the StaticDevContent is causing the issue on the Bureau results card. Should we remove it for this file?

@SidelineCory24
Copy link
Author

Bureau Position Details
image

@SidelineCory24
Copy link
Author

Bureau Results Card, couldn't find a good way to handle the box shadow.
image

@SidelineCory24
Copy link
Author

Compare List
image

@SidelineCory24
Copy link
Author

Bidder/CDO Position Details
image

@SidelineCory24
Copy link
Author

Search Results
image

@SidelineCory24
Copy link
Author

Condensed Card
image

@SidelineCory24
Copy link
Author

These are the designs I'll show to Chris and Sarah.

elizabeth-jimenez
elizabeth-jimenez approved these changes Apr 16, 2021
View reviewed changes
Copy link

@elizabeth-jimenez elizabeth-jimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 🧁 🍬 👍 cool job!

@SidelineCory24 SidelineCory24 merged commit 596f43d into dev Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabeth-jimenez elizabeth-jimenez elizabeth-jimenez approved these changes

@mjoyce91 mjoyce91 Awaiting requested review from mjoyce91

@scott062 scott062 Awaiting requested review from scott062

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SidelineCory24 @elizabeth-jimenez