Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding tooltip to ribbons in condensed card view #1481

Merged
merged 11 commits into from
May 5, 2021
Merged

adding tooltip to ribbons in condensed card view #1481

merged 11 commits into from
May 5, 2021

Conversation

SidelineCory24
Copy link

No description provided.

@SidelineCory24 SidelineCory24 added the WIP Work in progress label May 3, 2021
@SidelineCory24
Copy link
Author

The CN, HTF, and SND ribbons are wrapped in StaticDev causing the tooltip to align different than the handshake ribbon tooltip.

@SidelineCory24 SidelineCory24 removed the WIP Work in progress label May 4, 2021
@elizabeth-jimenez
Copy link

The CN, HTF, and SND ribbons are wrapped in StaticDev causing the tooltip to align different than the handshake ribbon tooltip.

Ah, nice observation!

@elizabeth-jimenez
Copy link

The position link is still activating when hovering on the ribbons for me

image

@SidelineCory24
Copy link
Author

SidelineCory24 commented May 5, 2021 •
edited

The position link is still activating when hovering on the ribbons for me

image

elizabeth-jimenez
elizabeth-jimenez reviewed May 5, 2021
View reviewed changes
src/Components/ResultsCondensedCardTop/ResultsCondensedCardTop.jsx Outdated
</Link>
<div {...containerProps}>
{ribbons}
<Link to={link} title="View details for this position">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure, but maybe keep {...containerProps} with the Link will fix the tooltip/link thing

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, but i'll look into it more ok, do the above comment but also move the class condensed-card-top from line 121 and put it on line 125

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

<div className="condensed-card-top">
    {ribbons}
    <Link to={link} {...containerProps} title="View details for this position">
        {innerContent}
    </Link>
</div>

elizabeth-jimenez
elizabeth-jimenez approved these changes May 5, 2021
View reviewed changes
Copy link

@elizabeth-jimenez elizabeth-jimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the typo, but besides that 🍬 🍰 🍥 👍

@SidelineCory24 SidelineCory24 merged commit ebb89e1 into dev May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabeth-jimenez elizabeth-jimenez elizabeth-jimenez approved these changes

@mjoyce91 mjoyce91 Awaiting requested review from mjoyce91

@scott062 scott062 Awaiting requested review from scott062

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SidelineCory24 @elizabeth-jimenez