Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add download link for Glossary #1727

Merged
merged 5 commits into from
Aug 24, 2021
Merged

Add download link for Glossary #1727

merged 5 commits into from
Aug 24, 2021

Conversation

mjoyce91
Copy link

@mjoyce91 mjoyce91 added the Release Priority to review for an upcoming release label Aug 23, 2021
@SidelineCory24
Copy link

@mjoyce91 should the underline be included as well? I reread slack and couldn't tell what the vote was on that in particular lol.
image

SidelineCory24
SidelineCory24 approved these changes Aug 23, 2021
View reviewed changes
Copy link

@SidelineCory24 SidelineCory24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of underline comment, Looks good to go!🚀

@mjoyce91 mjoyce91 merged commit cf29ff2 into dev Aug 24, 2021
@mjoyce91 mjoyce91 deleted the feature/glossary-download branch August 24, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SidelineCory24 SidelineCory24 SidelineCory24 approved these changes

@elizabeth-jimenez elizabeth-jimenez Awaiting requested review from elizabeth-jimenez

@scott062 scott062 Awaiting requested review from scott062

Assignees
No one assigned
Labels
Release Priority to review for an upcoming release
Projects
None yet
Milestone
No milestone
2 participants
@mjoyce91 @SidelineCory24