fix: update sort params to correctly sort #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjoyce91
reviewed
Jun 11, 2019
src/Constants/Sort.js
Outdated
| { value: '-position__bureau', text: 'Bureau: A-Z' }, // numbers first, then A-Z | ||
| { value: `-${COMMON_PROPERTIES.posted}`, text: 'Posted date: Most recent' }, // sort by soonest posted_date | ||
| { value: 'position__current_assignment__estimated_end_date', text: 'TED: Soonest' }, | ||
| { value: 'position__grade', text: 'Grade: Low to high' }, // sort by grade "ranking" |
There was a problem hiding this comment.
This should actually be -position__grade, as "06" is logically the "lowest" grade.
mjoyce91
reviewed
Jun 11, 2019
src/Constants/Sort.js
Outdated
| { value: `-${COMMON_PROPERTIES.posted}`, text: 'Posted date: Most recent' }, // sort by soonest posted_date | ||
| { value: 'position__current_assignment__estimated_end_date', text: 'TED: Soonest' }, | ||
| { value: 'position__grade', text: 'Grade: Low to high' }, // sort by grade "ranking" | ||
| { value: 'position__bureau', text: 'Bureau: A-Z' }, // numbers first, then A-Z |
|
The direction of all of these are backwards on my end |
|
@mjoyce91 fixed |
mjoyce91
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort params weren't sorting in the right direction or in some cases the correct field