Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align bid count with data points in ResultsCondensedCard #47

Merged
merged 3 commits into from
Dec 26, 2018

Conversation

mjoyce91
Copy link

Completes TM-337.

@rtirserio
Copy link

@mjoyce91 the cards on the search results are still pushed to the right. Does it make sense to make those consistent?

@mjoyce91
Copy link
Author

@rtirserio good point. @cydneycappello , do we also want to move the Bid Count on the search results cards?

How the condensed cards look with this PR's update:
screen shot 2018-12-21 at 9 37 06 am

The current search results cards:
screen shot 2018-12-21 at 9 37 14 am

@cydneycappello
Copy link

search results - no add to bid list
You guys are right, I had to mock it up to see it. But I think it looks better in-line.

@mjoyce91
Copy link
Author

Thanks, I'll update

@mjoyce91
Copy link
Author

@rtirserio - just updated

@mjoyce91 mjoyce91 merged commit 402bd13 into dev Dec 26, 2018
@burgwyn burgwyn deleted the fix/card-bid-count-style branch April 29, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants