Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wording for homepage position count #691

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Fix wording for homepage position count #691

merged 3 commits into from
Feb 6, 2020

Conversation

mjoyce91
Copy link

@mjoyce91 mjoyce91 commented Feb 6, 2020

  • Only use "there are more than..." text if positionCount > 50
  • Use "there is..." text if positionCount === 1

@elizabeth-jimenez
Copy link

@mjoyce91 👍

@mjoyce91 mjoyce91 merged commit c9092d1 into dev Feb 6, 2020
@mjoyce91 mjoyce91 deleted the fix/homepage-position-count branch February 6, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabeth-jimenez elizabeth-jimenez elizabeth-jimenez approved these changes

@scott062 scott062 Awaiting requested review from scott062

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mjoyce91 @elizabeth-jimenez