Fix/tests client badge list #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott062
commented
Mar 16, 2020
scott062
commented
- Tests for client badge list to 100%
- Tests for check box list to 100%
- Fixed props looking at numerals instead of stringed numerals
mjoyce91
reviewed
Mar 18, 2020
Comment on lines
8
to
85
| clientClassifications: ['3', 'T', 'C'], | ||
| classifications: [ | ||
| { | ||
| code: '3', | ||
| text: '3rd Tour Bidders', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: '4', | ||
| text: 'Tenured', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'D', | ||
| text: 'Differential Bidder', | ||
| disabled_ind: true, | ||
| }, | ||
| { | ||
| code: 'T', | ||
| text: 'Tandem Bidder', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'M', | ||
| text: 'Meritorious Step Increases', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: '6', | ||
| text: '6/8 Rule', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'F', | ||
| text: 'Fair Share Bidders', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'C', | ||
| text: 'Critical Need Language', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'C1', | ||
| text: 'Critical Need Language 1st Tour Complete', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'CC', | ||
| text: 'Critical Need Language Final Tour Complete', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'R', | ||
| text: 'Recommended for Tenure', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'A', | ||
| text: 'Ambassador or Deputy Assistant Secretary', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'F1', | ||
| text: 'Pickering Fellows', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'F2', | ||
| text: 'Rangel Fellows', | ||
| disabled_ind: false, | ||
| }, | ||
| { | ||
| code: 'P', | ||
| text: 'Pickering/Rangel Fellows', | ||
| disabled_ind: false, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Since you use these in multiple tests, abstract to a common variable
mjoyce91
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.