Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop for AccordionItem be either controlled or uncontrolled #849

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

mjoyce91
Copy link

Fixes a bug where non-multiselectable accordion items were not re-expanding on first click.

## Fixes a bug where non-multiselectable accordion items were not re-expanding on first click
Copy link

@elizabeth-jimenez elizabeth-jimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🍰 👍

@@ -108,6 +108,7 @@ class BidderPortfolioGridList extends Component {
{
results.map(result => (
<AccordionItem
controlled

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@mjoyce91 mjoyce91 merged commit 40cc066 into dev Apr 16, 2020
@mjoyce91 mjoyce91 deleted the fix/controlled-accordion branch April 16, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants