Fix bid tracker URL #863
Merged
Fix bid tracker URL #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabeth-jimenez
approved these changes
Apr 28, 2020
| (<ClosedAlert | ||
| title={BID_TITLE} | ||
| date={bid.closed_date} | ||
| id={bid.id} |
There was a problem hiding this comment.
Do we still need to send in id?
| /> | ||
| ); | ||
| break; | ||
| case DECLINED_PROP: | ||
| overlayClass = CLASS_CLOSED; | ||
| overlayContent = <DeclinedAlert bureau={position.bureau} id={bid.id} />; | ||
| overlayContent = <DeclinedAlert bureau={position.bureau} id={bid.id} bidIdUrl={bidIdUrl} />; |
There was a problem hiding this comment.
Good catch, removed. Re-running tests now
* dev: Remove unecessary data Update tests and fix props Update tests and fix condensed button Bump style-loader from 1.2.0 to 1.2.1 Map correct state to props for bid tracker with actions and remove unused vars Change border inside of register overlay to white Add shorthands Add registerHandshakePosition to mdp Allow CDOs to export a client's bid list to CSV Bump postcss-flexbugs-fixes from 4.2.0 to 4.2.1 Add styling for conditional rendering of the overlay to be full width of container below 1450px in order to avoid long name collisions Shorten button in condensed form Remove tooltip on tracker for cdo view of register hs Add bid tracker styling for new overlay alert Bump eslint-loader from 4.0.1 to 4.0.2 Bump eslint-loader from 4.0.0 to 4.0.1 Check CDO role from the roles array, instead of the user profile object Add reducers # Conflicts: # src/Components/BidTracker/BidTrackerCard/BidTrackerCard.jsx # src/Components/BidTracker/OverlayAlert/OverlayAlert.jsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "Go to Bid Tracker" button from the condensed bid tracker when a CDO is looking at a client's public profile. Resolves a bug where the the CDO was directed to their own bid tracker instead of the client's.