Feature/comparison drawer #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjoyce91
commented
Feb 23, 2019
mjoyce91
commented
- Adds Comparison Drawer to the results page
- Uses event listeners to sync local storage states between drawer and compare "checks" in results cards
- Currently disabled functionality to hide the Comparison drawer if the user reaches a certain scroll distance from the bottom (disabled and set to 0 per design feedback, but wanted to keep functionality included)
* dev: Code smells (#86) # Conflicts: # src/Components/CompareCheck/CompareCheck.jsx
rtirserio
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.