Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded values in ddi_2_5-cessda_eqb.xslt #20

Open
borsna opened this issue Apr 25, 2022 · 2 comments
Open

Remove hard coded values in ddi_2_5-cessda_eqb.xslt #20

borsna opened this issue Apr 25, 2022 · 2 comments

Comments

@borsna
Copy link
Contributor

borsna commented Apr 25, 2022

Hard coded values should be avoided.
Some example of hard coded values in the XSLT:

holdings:

<holdings URI="http://www.adp.fdv.uni-lj.si/opisi/">Arhiv družboslovnih podatkov</holdings>

qstn@xml:lang:
https://github.com/MetadataTransform/ddi-xslt/blob/master/transformations/cessda-eqb/from-ddi-2.5/ddi_2_5-cessda_eqb.xslt#L170

labl@xml:lang:
https://github.com/MetadataTransform/ddi-xslt/blob/master/transformations/cessda-eqb/from-ddi-2.5/ddi_2_5-cessda_eqb.xslt#L209

var@xml:lang:
https://github.com/MetadataTransform/ddi-xslt/blob/master/transformations/cessda-eqb/from-ddi-2.5/ddi_2_5-cessda_eqb.xslt#L136

Values should come for source XML document or via xsl:param

@borsna borsna changed the title Remove hard coded value for holdings Remove hard coded values in ddi_2_5-cessda_eqb.xslt Apr 25, 2022
@borsna
Copy link
Contributor Author

borsna commented Apr 25, 2022

@zibertg could you take a look at these cases?
The XSLT works fine but i think some hard coded values should be fixed so the XSLT works in a more general way for any DDI 2.5 XML-file.

Best regards,
Olof

@zibertg
Copy link
Contributor

zibertg commented May 3, 2022

Agreed, for reuse of the XSLT hardcoded fields should be removed. Uploaded the updated XSLT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants