Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mypy for static type checking #111

Open
regDaniel opened this issue Nov 15, 2023 · 2 comments
Open

Use mypy for static type checking #111

regDaniel opened this issue Nov 15, 2023 · 2 comments
Labels
enhancement New feature or request todo Something that devs agree should be done

Comments

@regDaniel
Copy link
Collaborator

Describe the new feature

Currently mypy is not used in this project. For the scope of it, stability is of utmost importance and we should use a static type checker to avoid unnecessary TypeErrors at runtime.
@regDaniel regDaniel added the todo Something that devs agree should be done label Nov 15, 2023
@regDaniel regDaniel changed the title Use mypy for static type checking [New Feature]: [New Feature]: Use mypy for static type checking Nov 15, 2023
@regDaniel regDaniel added the enhancement New feature or request label Nov 15, 2023
@regDaniel regDaniel changed the title [New Feature]: Use mypy for static type checking Use mypy for static type checking Nov 15, 2023
@fpavogt
Copy link
Member

fpavogt commented Apr 23, 2024

Should this be linked to #121 (and closed when this PR gets merged) ? Or is the idea behind this Feature to have a more formal implementation of mypy ?

@regDaniel
Copy link
Collaborator Author

There's one other task still to follow: We'll add mypy to the linting actions workflow, we have an AMAROC ticket for that, which we will address in the next 3 weeks. Then we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request todo Something that devs agree should be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fpavogt @regDaniel