Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published version on atmosphere includes eslint (increases package size by at least 9MB) #246

Closed
SimonSimCity opened this issue Sep 9, 2018 · 5 comments
Labels

Comments

@SimonSimCity
Copy link
Member

SimonSimCity commented Sep 9, 2018

The version currently available at atmosphere includes the npm package eslint and some related packages. This increases the size my project by 9MB - by packages which are only used when developing this package.

These packages were most-likely installed because they're listed in the package.json file. Before publishing you called something like npm install without the --production flag or at least didn't remove the superfluous packages by calling npm prune --production.

Would you have the chance and time to republish this package without the npm development packages? Thanks in advance.

Hint: The guys of meteor-publish-composite did the same mistake and are now using a script that ensures this mistake isn't happening again. See Meteor-Community-Packages/meteor-publish-composite@c17a166

@SimonSimCity SimonSimCity changed the title Republish latest version without npm-packages Published version on atmosphere includes eslint (increases package size by at least 9MB) Sep 9, 2018
@sakulstra
Copy link
Contributor

yep noticed this as well - making the package one of the biggest we have in the bundle :)

@sakulstra
Copy link
Contributor

sakulstra commented Sep 28, 2018

We currently face some build time issues and it seems like this is one of the causes - using a forked package without the npm dependencies dropped the build time by 40s. @zimme would you be able to publish a new version without the npm dependencies included inside the bundle? 🙏

@sakulstra
Copy link
Contributor

sakulstra commented Oct 9, 2018

published a fork without the npm modules as sakulstra:collection-hooks@0.9.0-rc.4 (we can no longer wait as this breaks our cd), i'm not planning on maintaining it but feel free to use it till this package receives an update

@SimonSimCity
Copy link
Member Author

Since other libraries are depending on this package I have to check it out and add it into the packages folder.

@StorytellerCZ
Copy link
Member

I will fix this in 0.9.1 by adding npm prune --production to the publication script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants