Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or incorporate practicalmeteor:mocha-core #8

Closed
0o-de-lally opened this issue Feb 17, 2017 · 2 comments
Closed

Update or incorporate practicalmeteor:mocha-core #8

0o-de-lally opened this issue Feb 17, 2017 · 2 comments

Comments

@0o-de-lally
Copy link
Contributor

practicalmeteor:mocha-core hasn't been maintained since June 2016, It may be worth preventively updating the packages there.

It's not a big package, and I'm not sure if the separation of concerns is critical in this case. It may be worth incorporating it here. For example: Some features such as grep, or custom reporters would need patching to the practicalmeteor:mocha-core code.

@0o-de-lally 0o-de-lally changed the title Update packages in practicalmeteor:mocha-core Update or incorporate practicalmeteor:mocha-core Feb 17, 2017
@aldeed
Copy link
Contributor

aldeed commented Feb 19, 2017

I collaborated with them on that package, and we need to use the same core package as practicalmeteor:mocha in order to avoid dependency issues when your app uses both drivers. I'd like to discuss with the practicalmeteor guys possible moving all of these test packages into a "testing" org or something like that so that we can maintain them all together.

One thing we could look at doing is to make mocha NPM package a peer dependency, in which case the mocha-core pkg will likely never need any updating unless the mocha API changes.

@SimonSimCity
Copy link
Member

We've created a fork which we now will support on our own: https://github.com/meteortesting/meteor-mocha-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants