Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not async? #395

Closed
carlosalvidrez opened this issue May 16, 2024 · 3 comments
Closed

Not async? #395

carlosalvidrez opened this issue May 16, 2024 · 3 comments
Labels

Comments

@carlosalvidrez
Copy link

Describe the bug

Meteor migration helper reports the server _roles method not being async.

W20240516-13:25:36.457(-4)? (STDERR) Deprecated (Publication): _roles is not async, consider migrating now. W20240516-13:25:36.457(-4)? (STDERR) => at module (packages/alanning:roles/roles/roles_server.js:30:8)

Expected behavior

I assume the presence of the meteor migration helper package should NOT report the serve roles method being not async.
https://github.com/jankapunkt/meteor-migration-helper

Additional context

Migrating to Meteor v3, using the latest version of this package.

Copy link

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously.
Our goal is to provide long-term lifecycles for packages and keep up
with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time.
Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit
a pull request, too! We will accompany you in the process with reviews and hints
on how to get development set up.

Please also consider sponsoring the maintainers of the package.
If you don't know who is currently maintaining this package, just leave a comment
and we'll let you know

@carlosalvidrez
Copy link
Author

Another debug report that may be helpful, thanks!

Deprecated: Collection.findOne needs to be migrated to findOneAsync in collection "roles"! => at Object._addUserToRole (packages/alanning:roles/roles/roles_common.js:463:31)

@carlosalvidrez
Copy link
Author

Not sure this is valid after all... now that I upgraded to v3, this doesn't happen anymore, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant