-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't deploy Meteor 0.9.1.1 project to Heroku that uses fourseven:scss package #41
Comments
+1 |
1 similar comment
+1 |
I just tried deploying with my app upgraded to meteor 0.9.3-rc5, which has a fix for the
|
Before upgrading to meteor 0.9, I was using version 0.9.3 of this package. I am now using version 0.9.5. This error seems to be coming from node-sass, but this package did not upgrade the version of node-sass being used between 0.9.3 and 0.9.5. |
Ok, I managed to find where my copies of 0.9.3 and 0.9.5 are stored. I examined the binding.node files for node-sass in both versions with the readelf command. It looks like the file in 0.9.5 depends on the glibc 2.14 version of the memcpy function while the file in 0.9.3 does not. A few years ago, a change was made to glibc's implementation of the memcpy function which broke some badly-written programs. In order to reduce some of the effects of this change, a new symbol version for memcpy was introduced. In the new version of glibc with the new implementation of memcpy, binaries referencing memcpy with the old symbol version would get the old version of memcpy which had the old behavior that everyone expected. Binaries referencing it with the new symbol version would get the new behavior. Only newly-compiled programs compiled against the new version of glibc would reference the new version of memcpy. Unfortunately this also means that these programs can't be run against older versions of glibc, even though they would probably work if the version requirement were lifted. Here are a few links: https://bugzilla.redhat.com/show_bug.cgi?id=638477 However, I realize that you guys probably don't care about this ancient history, so I'll move on. Heroku's "cedar" stack (https://devcenter.heroku.com/articles/cedar), which you are most likely running, uses Ubuntu 10.04. As you can see here: http://packages.ubuntu.com/lucid/libc6, that version of Ubuntu doesn't have a new enough libc version. However, all is not lost - that article on cedar describes an experimental "cedar-14" stack, which uses Ubuntu 14.04. As you can see here: http://packages.ubuntu.com/trusty/libc6, that version of Ubuntu has a more than new enough libc version. As this: https://devcenter.heroku.com/articles/stack#changing-stacks page describes, you can switch stacks like so:
which will take effect at your next push. This seems to allow meteor-scss to run for me. Unfortunately, I'm now having trouble with importing scss files from other packages, such as https://atmospherejs.com/matthew/foundation5-sass. The import seems to not work the first time meteor is run, and then works on subsequent runs. That's only a minor nuisance during development, but it becomes a show-stopper when you're using an automated build script which only attempts to build once. :( To the maintainer: if you'd like to support people running this package on heroku's cedar stack or other older Linux distros, you'll unfortunately need to build it on a machine/vm with an older version of glibc. |
@atrigent, awesome response! I changed to the cedar-14 stack, and now this package is working like a charm. Thank you 👍 I was using https://atmospherejs.com/reywood/bootstrap3-sass, but found that it was failing to compile on a fresh deploy (probably similar to the issue you are having with the foundation package). Instead I have included the bootstrap-sass files manually for now, and that's working for me. |
I'm closing this issue as it was a Heroku problem, not the author's problem. |
@atrigent thanks 👍 |
I am working on a project that deployed fine to Heroku when using Meteor 0.8.7 and the Meteorite version of this SCSS package. I updated Meteor to 0.9.0.1 and ever since I haven't been able to deploy to Heroku, but only if I include this package. Running the site locally works fine - it's only the Heroku deploy that breaks.
I've been able to replicate the issue by simply taking the leaderboard example, adding fourseven:scss, changing
leaderboard.css
and renaming it toleaderboard.scss
, and deploying that to Heroku using this buildpack: https://github.com/djhi/heroku-buildpack-meteorite.gitThis is the error message that I am getting:
The text was updated successfully, but these errors were encountered: