Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using lint-staged #1

Open
copleykj opened this issue Mar 12, 2020 · 7 comments
Open

Consider using lint-staged #1

copleykj opened this issue Mar 12, 2020 · 7 comments
Labels
good first issue Good for newcomers

Comments

@copleykj
Copy link
Member

It looks like preCommit.sh is basically doing what the lint-staged package does. Should we consider that instead?

@copleykj
Copy link
Member Author

ping @StorytellerCZ

@StorytellerCZ
Copy link
Member

🤔 I'm not sure. If we have a simple bash script that I think is preferable instead of adding additional package. It is also readable in regard what is going on and adjustable. On the other hand it is an extra file to maintain which might not be as bad with an extra package.

@copleykj
Copy link
Member Author

I'm perfectly comfortable with a bash script, however lint-staged is a cross platform solution which will also work for devs working on windows based environments. Yes it's an extra package, but it's also just a dev dependency and wouldn't affect the build at all.

@StorytellerCZ
Copy link
Member

OK, sounds good. Feel free to push the changes.

@StorytellerCZ
Copy link
Member

@copleykj The only current problem I see that we currently have StandardJS, which is a problem for lint-staged:
Cannot add lint-staged: only eslint, stylelint, prettier or custom rules are supported.

@copleykj
Copy link
Member Author

copleykj commented May 7, 2020

What about configuring eslint with eslint-plugin-standard?

@StorytellerCZ
Copy link
Member

Probably the way forward so that we can include Meteor specific rules as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants