Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed-up PTC fringe fields #1160

Open
ldeniau opened this issue Mar 1, 2023 · 2 comments
Open

Speed-up PTC fringe fields #1160

ldeniau opened this issue Mar 1, 2023 · 2 comments
Labels
enhancement the behaviour should be changed in the code sometime

Comments

@ldeniau
Copy link
Contributor

ldeniau commented Mar 1, 2023

In file Sh_def_kind.f90, set the global-to-module variable
n_wedge = 0
instead of 5, this will save 5*(8+7)*2 = 150 yrotation done for each element
@ldeniau
Copy link
Contributor Author

ldeniau commented Mar 9, 2023

As a side comment, in some conditions, these yrotation are needed to get accurate results... So this needs to be investigated further, even if it slows down PTC.

@rdemaria rdemaria added the enhancement the behaviour should be changed in the code sometime label Jun 21, 2023
@jgray-19 jgray-19 mentioned this issue Aug 16, 2023
Merged
@jgray-19
Copy link
Contributor

This has been implemented as of #1200.

@Porkepix Porkepix mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement the behaviour should be changed in the code sometime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rdemaria @ldeniau @jgray-19