Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make X11 optional #652

Merged
merged 4 commits into from Aug 10, 2018
Merged

Conversation

coldfix
Copy link
Collaborator

@coldfix coldfix commented Aug 1, 2018

Hi,

this adds a X11=yes/no switch to the build systems do disable usage of X11 on linux/mac. This can be useful to suppress link dependency on X11 when the libX11.a shipped in lib/ can not be used due to not being compiled with -fPIC (e.g. on some linux or when compiling shared objects).

Also cleanup some minor issues in cmake scripts.

@coveralls
Copy link

coveralls commented Aug 1, 2018

Coverage Status

Coverage remained the same at 53.803% when pulling 59d136a on hibtc:opt_X11 into ac9f584 on MethodicalAcceleratorDesign:master.

Allows to suppress the link dependency on X11 when the libX11.a shipped
in lib/ can not be used due to not being compiled with -fPIC (e.g. on
some linux or when compiling shared objects).
The compiler-agnostic CXX_STANDARD feature was added in cmake 3.1.
Copy link
Contributor

@tpersson tpersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tpersson tpersson merged commit 6448a10 into MethodicalAcceleratorDesign:master Aug 10, 2018
@coldfix coldfix deleted the opt_X11 branch August 12, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants