Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

Demo broken on IE11. Object.assign... #79

Closed
2 tasks done
neslinesli93 opened this issue Aug 21, 2017 · 6 comments
Closed
2 tasks done

Demo broken on IE11. Object.assign... #79

neslinesli93 opened this issue Aug 21, 2017 · 6 comments
Labels
bug

Comments

@neslinesli93
Copy link

I'm submitting a ...

  • bug report
  • feature request

Bug Report:

Demo is currently broken on IE11, with the message object doesn't support property or method 'includes'
@Metnew
Copy link
Owner

Metnew commented Aug 21, 2017 •
edited

Hm, ok will be fixed. Probably it's because of Array.includes

@neslinesli93
Copy link
Author

Actually just adding babel-polyfill to webpack config.entry production bundle may have solved the problem. However, it does not work in dev mode: after some research, it seems there is conflict between react hot loader and babel-polyfill module...

@Metnew
Copy link
Owner

Metnew commented Nov 4, 2017

Hi @neslinesli93 , can you check is your issue still reproducible?

@neslinesli93
Copy link
Author

Yep, now it complains about assign not being a property of Object

@Metnew
Copy link
Owner

Metnew commented Nov 4, 2017

Hm, strange... Probably, something with babel. Thanks for check 👍

@Metnew Metnew added the bug label Nov 4, 2017
@Metnew Metnew changed the title Demo broken on IE11 Demo broken on IE11. Object.assign... Nov 4, 2017
@Metnew
Copy link
Owner

Metnew commented Nov 10, 2017 •
edited

Should be fixed in #130. (demo hasn't updated yet, so try run it locally, please)

@Metnew Metnew closed this as completed Nov 10, 2017
@snyk-bot snyk-bot mentioned this issue Jun 1, 2020
Open
This was referenced Oct 5, 2022
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neslinesli93 @Metnew