Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Create a TurboPump component #292

Open
pierre-eliep-met opened this issue Oct 6, 2022 · 0 comments
Open

[FEATURE] Create a TurboPump component #292

pierre-eliep-met opened this issue Oct 6, 2022 · 0 comments
Assignees
@valentind-met @pierre-eliep-met
Labels
🆕 New component For new components added to the library

Comments

@pierre-eliep-met
Copy link
Collaborator

pierre-eliep-met commented Oct 6, 2022 •
edited

Is your feature request related to a problem? Please describe.

Following #99 discussions, we decided that it was relevant to add a turbopump component in WaterSteam.Machines.TurboPump, because it is a specific component, hard to model, with a complex causality, and handling power connectors caused issues.

Describe the solution you'd like
We could have a component with SteamInlet, SteamOutlet, FeedWaterInlet, FeedWaterOutlet, that way we can always add any sensor or component we want around, and it will give a causality hint too :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentind-met valentind-met

@pierre-eliep-met pierre-eliep-met

Labels
🆕 New component For new components added to the library
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

add-fwp-model Metroscope-dev/metroscope-modeling-library
2 participants
@valentind-met @pierre-eliep-met