Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Modify the causality of the GT example so that it matches our current standards #470

Open
helenev-met opened this issue Mar 22, 2024 · 0 comments
Labels
✨enhancement New feature or request 👨‍💻 Example Modified or added examples

Comments

@helenev-met
Copy link
Contributor

helenev-met commented Mar 22, 2024

What is not your precise need ?

Today :

  • TET is mentioned : so it is not a BC (either an input) -> it should be a BC
  • combustionChamber_eta is a parameter and is given a value -> should be an output calibrated by Q_gaz
  • Q_gaz in identified as a BC -> should be an input for calibration
  • Compressor outlet pressure is an input for calibration -> it should be a BC
  • And we should Identify that the turbine_expansion_rate remains free
  • Replace the enthalpy inputs by temperature inputs
    And it would be great to include sensors also for BC. But it's not a priority compared to the causality update👍
@helenev-met helenev-met added ✨enhancement New feature or request 👨‍💻 Example Modified or added examples labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨enhancement New feature or request 👨‍💻 Example Modified or added examples
Projects
None yet
Development

No branches or pull requests

1 participant