Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw outlines using draw() commands, rather than a second SVG #100

Closed
MewPurPur opened this issue Oct 20, 2023 · 0 comments · Fixed by #103
Closed

Draw outlines using draw() commands, rather than a second SVG #100

MewPurPur opened this issue Oct 20, 2023 · 0 comments · Fixed by #103
Assignees
Labels

Comments

@MewPurPur
Copy link
Owner

MewPurPur commented Oct 20, 2023

SVGs are really taxing on performance, so this should reduce the overhead of changing the SVG and zooming in/out by at least a little bit (probably by something like 40%).

This will also fix how these outlines aren't drawn outside the texture even if they stretch a little out.

Care should be taken to not draw a lot of lines out of bounds (like if you put x=999999 y=999999 as a curve end point in a path) as this might freeze the app if it's not done with care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant