Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Not Downloading After Adding downloader.ini #16

Closed
mjj03301977 opened this issue Apr 7, 2022 · 2 comments
Closed

Updates Not Downloading After Adding downloader.ini #16

mjj03301977 opened this issue Apr 7, 2022 · 2 comments

Comments

@mjj03301977
Copy link

So I created downloader.ini, copy/pasted the defaults and saved it into my root directory (where MiSTer.ini) lives. I noticed that when I run the downloader script now, nothing updates. After doing some research, I found that the downloader.ini needs to point to the default MiSTer [distribution_mister] database.

If this is the case, then shouldn't this be documented and added to the list of default ini settings?

@andshrew
Copy link

This is still an issue if you have created downloader.ini with reference to a custom database. The custom database will update but the default database is no longer updating. I can't see any reference to this being a requirement in the documentation here.

I created downloader.ini with the following contents:

[jtcores]
db_url = https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip

When I run downloader.sh the custom database will update successfully, but the default distribution_mister will not update at all. There are no errors reported. downloader.log shows:

/media/fat/Scripts# more /media/fat/Scripts/.config/downloader/downloader.log
START!

Reading file: /media/fat/downloader.ini
Reading 'jtcores' db section
env: {
    "DOWNLOADER_LAUNCHER_PATH": "./downloader.sh",
    "DOWNLOADER_INI_PATH": null,
    "CURL_SSL": "--cacert /etc/ssl/certs/cacert.pem",
    "COMMIT": "df11b74",
    "ALLOW_REBOOT": null,
    "UPDATE_LINUX": "true",
    "DEFAULT_DB_URL": "https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip",
    "DEFAULT_DB_ID": "distribution_mister",
    "DEFAULT_BASE_PATH": null,
    "DEBUG": "false",
    "FAIL_ON_FILE_ERROR": "false"
}
config: {
    "databases": {
        "jtcores": {
            "db_url": "https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip",
            "section": "jtcores"
        }
    },
    "config_path": "/media/fat/downloader.ini",
    "base_path": "/media/fat",
    "base_system_path": "/media/fat",
    "storage_priority": "prefer_sd",
    "allow_delete": 1,
    "allow_reboot": 1,
    "update_linux": true,
    "parallel_update": true,
    "downloader_size_mb_limit": 100,
    "downloader_process_limit": 300,
    "downloader_timeout": 300,
    "downloader_retries": 3,
    "zip_file_count_threshold": 60,
    "zip_accumulated_mb_threshold": 100,
    "filter": null,
    "verbose": false,
    "debug": false,
    "default_db_id": "distribution_mister",
    "start_time": 1652478757.261621,
    "user_defined_options": [],
    "curl_ssl": "--cacert /etc/ssl/certs/cacert.pem",
    "update_linux_environment": 0,
    "fail_on_file_error": false,
    "commit": "df11b74"
}
cacert file at "/etc/ssl/certs/cacert.pem" seems to be fine.
Loading db from url: https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip
Downloading 1 files:
/tmp/temp_filea7305eb9
*.

Checking hashes...
+
jtcores still uses base_path: /media/fat

################################################################################
SECTION: jtcores

Nothing new to download from given sources.
Skipping local_store saving...

===========================
Downloader 1.5 (df11b74) by theypsilon. Run time: 0:00:03.25s
Log: /media/fat/Scripts/.config/downloader/downloader.log

Installed:
none.

Errors:
none.

Running update_linux
linux_descriptions_count: 0

If I edit my downloader.ini to include a [distribution_mister] section as suggested by @mjj03301977 then the default database will now update again as expected when the script is run, along with the custom database. My downloader.ini now looks like this:

[distribution_mister]
db_url = https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip

[jtcores]
db_url = https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip

The truncated output from downloader.log

/media/fat# more /media/fat/Scripts/.config/downloader/downloader.log
START!

Reading file: /media/fat/downloader.ini
Reading 'distribution_mister' db section
Reading 'jtcores' db section
env: {
    "DOWNLOADER_LAUNCHER_PATH": "./downloader.sh",
    "DOWNLOADER_INI_PATH": null,
    "CURL_SSL": "--cacert /etc/ssl/certs/cacert.pem",
    "COMMIT": "df11b74",
    "ALLOW_REBOOT": null,
    "UPDATE_LINUX": "true",
    "DEFAULT_DB_URL": "https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip",
    "DEFAULT_DB_ID": "distribution_mister",
    "DEFAULT_BASE_PATH": null,
    "DEBUG": "false",
    "FAIL_ON_FILE_ERROR": "false"
}
config: {
    "databases": {
        "distribution_mister": {
            "db_url": "https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip",
            "section": "distribution_mister"
        },
        "jtcores": {
            "db_url": "https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip",
            "section": "jtcores"
        }
    },
    "config_path": "/media/fat/downloader.ini",
    "base_path": "/media/fat",
    "base_system_path": "/media/fat",
    "storage_priority": "prefer_sd",
    "allow_delete": 1,
    "allow_reboot": 1,
    "update_linux": true,
    "parallel_update": true,
    "downloader_size_mb_limit": 100,
    "downloader_process_limit": 300,
    "downloader_timeout": 300,
    "downloader_retries": 3,
    "zip_file_count_threshold": 60,
    "zip_accumulated_mb_threshold": 100,
    "filter": null,
    "verbose": false,
    "debug": false,
    "default_db_id": "distribution_mister",
    "start_time": 1652479305.8439555,
    "user_defined_options": [],
    "curl_ssl": "--cacert /etc/ssl/certs/cacert.pem",
    "update_linux_environment": 0,
    "fail_on_file_error": false,
    "commit": "df11b74"
}
cacert file at "/etc/ssl/certs/cacert.pem" seems to be fine.
Loading db from url: https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip
Loading db from url: https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip
Downloading 2 files:
/tmp/temp_fileasx16fmx
/tmp/temp_fileo15qq54_
*..

Checking hashes...
++
distribution_mister still uses base_path: /media/fat
jtcores still uses base_path: /media/fat

################################################################################
SECTION: distribution_mister

Downloading 17 files:
/tmp/atari7800_palettes_summary.json.zip
/tmp/cheats_folder_gameboy_summary.json.zip
/tmp/cheats_folder_gba_summary.json.zip
/tmp/cheats_folder_genesis_summary.json.zip
/tmp/cheats_folder_nes_summary.json.zip
/tmp/cheats_folder_psx_summary.json.zip
/tmp/cheats_folder_sms_summary.json.zip
/tmp/cheats_folder_snes_summary.json.zip
/tmp/cheats_folder_tgfx16-cd_summary.json.zip
/tmp/cheats_folder_tgfx16_summary.json.zip
/tmp/gameboy2p_palettes_summary.json.zip
/tmp/gameboy_palettes_summary.json.zip
/tmp/global_filters_summary.json.zip
/tmp/global_fonts_summary.json.zip
/tmp/global_shadow_masks_summary.json.zip
/tmp/mra_alternatives_summary.json.zip
/tmp/nes_palettes_summary.json.zip
.................

Checking hashes...
+++++++++++++++++

Removing /media/fat/_Arcade/cores/DonkeyKong_20211126.rbf
Removing /media/fat/_Arcade/cores/Finalizer_20220101.rbf
Removing /media/fat/_Arcade/cores/IronHorse_20211225.rbf
Removing /media/fat/_Arcade/cores/Jackal_20211225.rbf
Removing /media/fat/games/NES/blank.sav
Removing /media/fat/_Console/Gameboy_20220326.rbf
Removing /media/fat/_Console/GBA_20220417.rbf

Downloading 9 files:
/tmp/cheats_folder_gameboy_contents.zip
/tmp/cheats_folder_gba_contents.zip
/tmp/cheats_folder_genesis_contents.zip
/tmp/cheats_folder_nes_contents.zip
/tmp/cheats_folder_psx_contents.zip
/tmp/cheats_folder_sms_contents.zip
/tmp/cheats_folder_snes_contents.zip

*** truncated ***

Checking hashes...
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Copying new MiSTer binary:
New MiSTer binary copied.

################################################################################
SECTION: jtcores

Nothing new to download from given sources.

===========================
Downloader 1.5 (df11b74) by theypsilon. Run time: 0:03:53.27s
Log: /media/fat/Scripts/.config/downloader/downloader.log

Installed:
MiSTer, DonkeyKong_20220502.rbf, Finalizer_20220511.rbf, IronHorse_20220511.rbf, Jackal_20220511.rbf, SNK_TripleZ80_20220510.rbf, GBA_20220428.rbf, Gameboy_20220429.rbf, PSX_20220511.rbf, ASO.mra, Finalizer - Super Transformation (Set 1).mra, Finalizer - Super Transformation (Set 2) [bl].mra, Finalizer - Super Transformation (Set 2).mra, MRA Alternatives + other files.

Errors:
none.

Running update_linux
linux: {
    "hash": "9999c8118b12a8ee94d85d6492ff22b2",
    "size": 91966791,
    "url": "https://raw.githubusercontent.com/MiSTer-devel/SD-Installer-Win64_MiSTer/135972e4ea840cda1cb38a467ab63ade364f9db2/release_20220413.7z",
    "version": "220413"
}
current_linux_version "220413" matches db linux: 220413

Rebooting in 10 seconds...


If this is intended could reference to it be added to the documentation?

@theypsilon
Copy link
Member

Thank you. You are right, it should be clarified in the documentation, I added it here: 19343c1

Feel free to let me know if you find something else to improve in the docs. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants