Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rayman (USA) // REGRESSION - Missing some CDDA audio frames when reading some tracks (CHD only) #141

Closed
Zet-sensei opened this issue Feb 29, 2024 · 6 comments

Comments

@Zet-sensei
Copy link

Zet-sensei commented Feb 29, 2024

With recent changes to SCSP (commit f0aa89a), CDDA tracks in several games like Rayman (one of the most striking examples) are now played with some audio frames too late.

Confirmed also by another user on Discord.

Tested with Main MiSTer Unstable version 2024-02-28 and core version 2024-02-29

@Zet-sensei Zet-sensei changed the title Rayman (USA) // CDDA tracks are read too late Rayman (USA) // REGRESSION - CDDA tracks are read too late Feb 29, 2024
@Zet-sensei
Copy link
Author

Further investigations are necessary.
Will update the problem report accordingly.

@Zet-sensei
Copy link
Author

Zet-sensei commented Mar 1, 2024

After some more tests, the recent commit (2024-02-28) on Main MiSTer should be at fault MiSTer-devel/Main_MiSTer@29fb819

If I revert to MiSTer Unstable Main 20240225, the issue is gone.
And if I try once more to change it back to MiSTer Unstable Main 20240229, the problem reappears.

Maybe some changes on the decode INDEX commands to check ?
As the INDEX 01 on that game isn't constant between CDDA tracks (either 00:02:00 INDEX01 or 00:02:02 INDEX01).

Tested with a CHD version of the game.

@Zet-sensei
Copy link
Author

Zet-sensei commented Mar 1, 2024

After some tests with a Redump formated version of the game, the issue isn't present anymore (decompressing the same CHD file to multiple BIN files + single CUE file).

Reverting to a 2024-02-25 version of the Main MiSTer file, we could load the two versions of the game without the issue too.

@Zet-sensei Zet-sensei changed the title Rayman (USA) // REGRESSION - CDDA tracks are read too late Rayman (USA) // REGRESSION - Missing some CDDA audio frames when reading some tracks (CHD only) Mar 1, 2024
@real-amano
Copy link

real-amano commented Mar 2, 2024

MiSTer-devel/Main_MiSTer#879
CHD compatibility seems to be in place now. Or at least improved.

BTW, if somebody tested Rayman again, could you check if issue #4 is still not fixed?

@Zet-sensei
Copy link
Author

Not fixed for both issues.
I'm already checking regulary my opened issues, thanks.

@Zet-sensei
Copy link
Author

Zet-sensei commented Mar 4, 2024

Tested and confirmed as fixed with an upcoming PR (MiSTer-devel/Main_MiSTer#880) on the Main MiSTer file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants