Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict eval #215

Open
davidak opened this issue Aug 16, 2021 · 1 comment
Open

strict eval #215

davidak opened this issue Aug 16, 2021 · 1 comment

Comments

@davidak
Copy link

davidak commented Aug 16, 2021

ofborg has a more strict eval than nixpkgs-review

this lead to me merging a pr that worked fine in nixpkgs-review test but broke master

reason was that an alias was used what is not allowed since NixOS/ofborg#250

so, to prevent breaking nixpkgs, nixpkgs-review eval should be in sync with ofborg

@Mic92
Copy link
Owner

Mic92 commented Aug 16, 2021

We have implemented disabling aliases here: ab4a35d
It is not yet released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants