Trying to review linux builds on osx with remote build fails

[tricktron]

I am on OSX Catalina and I try to review if my own pull request regarding openconnet also works on linux by using linuxkit-nix and nix-review:

nix-shell -p nix-review
nix-review pr --build-args="--builders ssh://root@nix-linuxkit --argstr system x86_64-linux" 71318

Unfortunately it fails with the error:

build of '/nix/store/7g2nsd32plad8ipnqii5z2qivfl7mjjq-bash-completion-2.9.drv'
on 'ssh://root@nix-linuxkit' failed: a 'x86_64-darwin' is required to build
'/nix/store/7g2nsd32plad8ipnqii5z2qivfl7mjjq-bash-completion-2.9.drv', but I am a ### 'x86_64-linux'

If I try it with the --option arg:
nix-review pr --build-args="--builders ssh://root@nix-linuxkit --option system x86_64-linux" 71318

it fails silently by somehow skipping the build because I get the following output:

7 package are marked as broken and were skipped
connman_dmenu gnome3.nautilus-python libsForQt5.alkimia
libsForQt511.alkimia libsForQt512.alkimia networkmanager_dmenu strongswanNM

2 package failed to build:
openconnect openconnect_openssl

Possibly related issues who tried the same using nix-docker.

Using just build --option build-use-sandbox true --argstr system x86_64-linux -A openconnect works just fine.

[tricktron]

It was a problem related to the bash-completion-2.9 derivation which was solved with this pull request . So I am going to close this here now.

[Mic92]

Note that for remote builders crossing architectures we only build packages that can be evaluated on the current system and not the system that you set with --build-args:

https://github.com/Mic92/nix-review/blob/master/nix_review/review.py#L26

We need a proper --system flag to cover that.

[tricktron]

Thanks for the answer. How would you achieve such a proper --system flag?

[Mic92]

The value needs to be passed to https://github.com/Mic92/nix-review/blob/master/nix_review/review.py#L160 (used for local evaluation) and https://github.com/Mic92/nix-review/blob/master/nix_review/review.py#L30 (used when processing ofborg's evaluation) so both returns the packages for the target system and not the system nix-review is running on.