Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weathergov: Removed weatherEndpoint. Added hourly under "Type:" #132

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

dWoolridge
Copy link
Contributor

The weatherEndpoint option is not used by the weathergov.js provider, and should be removed from the docs.

Hourly weather support will be added the weathergov provider in MagicMirror v2.22.0.
@dWoolridge dWoolridge changed the title Removed weatherEndpoint option from Weather.gov weathergov: Removed weatherEndpoint. Added hourly under "Type:" Oct 6, 2022
Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. You might also want to remove it from the code if you got the time :-)

@rejas
Copy link
Collaborator

rejas commented Oct 6, 2022

Fixes #131 by the way :-)

@dWoolridge
Copy link
Contributor Author

rejas,

weatherEndpoint only shows up once in weathergov.js in the default definitions. I've removed that setting in my fork. Should I create another pull request for that change?

@rejas
Copy link
Collaborator

rejas commented Oct 6, 2022

that would be very helpful, yes :-)

I noticed you work here on your master branch. Its always helpful (in case one is working on multiple stuff at the same time) to make a branch (in this repo from master or from develop in case of the magicmirror repository)

@dWoolridge
Copy link
Contributor Author

rejas,

Just so I understand... I should have created a branch within dWoolridge/MagicMirror-Documentation? I only see the master branch for MichMich/MagivMirror-Documentation, so that's what I duplicated in my work.

@rejas
Copy link
Collaborator

rejas commented Oct 7, 2022

yes, the original repo here has only one branch, master. But you can always create a new branch from any branch (including master) with a name of your choosing.

That way you can work in branch "update_weather_doc" while having another branch "update_calendar_doc" with the changes nicely seperated.

@MichMich MichMich merged commit fa297e1 into MagicMirrorOrg:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants