Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM warnings when running npm install. #567

Closed
MichMich opened this issue Dec 13, 2016 · 5 comments
Closed

NPM warnings when running npm install. #567

MichMich opened this issue Dec 13, 2016 · 5 comments

Comments

@MichMich
Copy link
Collaborator

When installing the node dependencies, the installer ends with a warning:

npm WARN grunt-yamllint@0.2.0 requires a peer of grunt@~0.4.0 but none was installed.
npm WARN stylelint-config-standard@15.0.0 requires a peer of stylelint@^7.6.0 but none was installed.

This resulted in a lot of people thinking they were unable to install the application.

@nhubbard Since this is a direct result of the linters, is this something you can look into? A PR solving this issue would be very welcome. (And I'd like to include this fix in the release of 2.1.0)

Thanks!

@nhubbard
Copy link
Contributor

@MichMich This is a slight concern of mine. From what it appears, the packages have peer dependencies, which npm versions greater than 2 will warn you about. To fix this issue, all our npm install commands need to have the --loglevel error flag on them, which according to here implies that only errors will trigger logging. Either that, or we can add an install script that just prints "Install successful!" in green to let the user know that the system is all good. Either one is your choice! I welcome the use of either or both in conjunction. 👍

@MichMich
Copy link
Collaborator Author

Send me a PR with your personal favourite ;) The loglevel seems like a good idea. For most users, the warnings are unimportant.

@MichMich
Copy link
Collaborator Author

@nhubbard Still willing to fix this? :)

@nhubbard
Copy link
Contributor

@MichMich Sorry, exams have got me looking left, right and center on studying. I'll try to get to it this weekend if I have time.

@roramirez
Copy link
Contributor

Note: This warning should disappear with the last update of grunt-yamllint
geedew/grunt-yamllint@55652f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants