Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather refactoring #1488

Merged
merged 35 commits into from Dec 28, 2018
Merged

Weather refactoring #1488

merged 35 commits into from Dec 28, 2018

Conversation

fewieden
Copy link
Contributor

  • Fixed openweathermap
  • Fixed darksky
  • Implemented forecast for both
  • added indoor values
  • documentation
  • ...

current
forecast

@fewieden
Copy link
Contributor Author

Some things are still missing:

  • feels like temperature
  • openweathermap forecast for newer api keys (grouping 3h forecasts)
  • darksky unit handling
  • some more config options from the previous modules

But I would categorize those more as improvements.

@fewieden
Copy link
Contributor Author

The build on travis only failed for 50%. Nodejs can't handle class and in the other one the before hooks timed out as seen previously

@MichMich
Copy link
Collaborator

SUPER AWESOME WORK! 🎉

If we can find a way to make travis happy, I can merge it, and then merge it into develop so we can shift the module as EXPERIMENTAL, which will hopefully increase traction in the development.

I'll be releasing the next MM version January 1st, so lets try to get it included in this version! :)

@fewieden fewieden changed the base branch from weather-refactor to develop December 27, 2018 22:04
@MagicMirrorBot
Copy link

Warnings
⚠️

Please include an updated CHANGELOG.md file.
This way we can keep track of all the contributions.

Generated by 🚫 dangerJS

@fewieden
Copy link
Contributor Author

@MichMich I merged current develop branch (has an updated travis config) into the weather branch. It passed now.

@MichMich MichMich merged commit b94dc50 into MagicMirrorOrg:develop Dec 28, 2018
@MichMich
Copy link
Collaborator

Great work! Ill make sure to merge it into dev before releasing a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants