Do not run updateDom() on hidden modules. #2166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
rejas
reviewed
Oct 14, 2020
js/main.js
Outdated
| @@ -110,6 +110,10 @@ var MM = (function () { | |||
| * @returns {Promise} Resolved when the dom is fully updated. | |||
| */ | |||
| var updateDom = function (module, speed) { | |||
| if (module.hidden) { | |||
| return; | |||
There was a problem hiding this comment.
The function should return a Promise.
There was a problem hiding this comment.
Do you suggest an empty promise?
…estriction fix currentweather and weatherforecast show()ing all the time
This was referenced Sep 12, 2021
This was referenced May 9, 2023
This was referenced Jun 20, 2023
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules update their dom even when they are hidden. This PR prevents modules from running updateDom whenever the module is hidden. This should fix #2161 #2164.