Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-CloudShell | Syntax error when selecting scenes #3880

Closed
ravenclaw900 opened this issue Oct 30, 2020 · 1 comment
Closed

DietPi-CloudShell | Syntax error when selecting scenes #3880

ravenclaw900 opened this issue Oct 30, 2020 · 1 comment
Labels
Bug 🐞 Solution available 🥂 Definite solution has been done
Milestone

Comments

@ravenclaw900
Copy link
Collaborator

ravenclaw900 commented Oct 30, 2020

Creating a bug report/issue

Required Information

  • DietPi version | cat /boot/dietpi/.version
    G_DIETPI_VERSION_CORE=6
    G_DIETPI_VERSION_SUB=33
    G_DIETPI_VERSION_RC=3
    G_GITBRANCH='master'
    G_GITOWNER='MichaIng'
  • Distro version | echo $G_DISTRO_NAME or cat /etc/debian_version
    buster
  • Kernel version | uname -a
    Linux rpi4 5.4.72-v7l+ https not working for Punycode domain #1356 SMP Thu Oct 22 13:57:51 BST 2020 armv7l GNU/Linux
  • SBC model | echo $G_HW_MODEL_NAME or (EG: RPi3)
    RPi 4 Model B (armv7l)
  • Power supply used | (EG: 5V 1A RAVpower)
    CanaKit
  • SDcard used | (EG: SanDisk ultra)
    Samsung EVO+ 32GB

Additional Information (if applicable)

  • Software title | (EG: Nextcloud)
    DietPi-Cloudshell
  • Was the software title installed freshly or updated/migrated?
    Installed freshly
  • Can this issue be replicated on a fresh installation of DietPi?
    Maybe, with Pi-hole
  • Bug report ID | echo $G_HW_UUID
    76ad71ff-c5fc-4aba-a569-4778f576e96d

Steps to reproduce

  1. Try to change add DietPi-Cloudshell Pi-hole scene

Expected behaviour

  • The scene should be added with no error

Actual behaviour

  • Syntax error

Extra details

  • /boot/dietpi/dietpi-cloudshell: line 1494: 0 1 2 3 4 5 6 7 8 : syntax error in expression (error token is "1 2 3 4 5 6 7 8 ")
  • Pi-hole is installed
@MichaIng
Copy link
Owner

MichaIng commented Oct 30, 2020

Many thanks for your report.

The Pi-hole scene does not work well since Pi-hole v5 where Gravity does not use a text file but a database file instead. However, there is a syntax bug: 1155a4b
Changelog: d676792

Quick fix:

grep -qF '"${G_WHIP_RETURNED_VALUE[@]}"' /boot/dietpi/dietpi-cloudshell && sed -i 's/"${G_WHIP_RETURNED_VALUE\[@\]}"/$G_WHIP_RETURNED_VALUE/' /boot/dietpi/dietpi-cloudshell

@MichaIng MichaIng added Bug 🐞 Solution available 🥂 Definite solution has been done labels Oct 30, 2020
@MichaIng MichaIng added this to the v6.34 milestone Oct 30, 2020
@MichaIng MichaIng mentioned this issue Dec 8, 2020
@MichaIng MichaIng changed the title DietPi-Cloudshell error when adding Pi-hole scene DietPi-CloudShell | Syntax error when selecting scenes Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Solution available 🥂 Definite solution has been done
Projects
None yet
Development

No branches or pull requests

2 participants