Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@class and @protocol declarations take up too much room #1

Closed
AriX opened this issue Jul 17, 2015 · 2 comments
Closed

@class and @protocol declarations take up too much room #1

AriX opened this issue Jul 17, 2015 · 2 comments

Comments

@AriX
Copy link

AriX commented Jul 17, 2015

The @Class and @protocol declarations at the top of every header file take up a ton of room and make it difficult to read the actual interfaces.

I'd suggest doing: "@Class MAIDataAsset, MAILayoutXAxisAnchor, MAILayoutYAxisAnchor, " etc and getting it all taken care of on one line rather than >100 lines being protocol and class declarations.

Additionally, I don't believe it's necessary to to #import TargetConditionals.h if you are importing UIKit and AppKit?

@MichaelBuckley
Copy link
Owner

Absolutely. Improving the readability and formatting of the headers is a high priority for this project, and all those class and protocol declarations are the biggest problems in that regard. They are that way now because I originally envisioned being able to declare just the classes and protocols needed for that header, under the mistaken assumption that the declarations improved the self-documentation of the code, but I never got around to implementing that in the generator.

Combining the declarations into two lines total is a good one, but I think moving them to their own separate header would be even better. Thanks for filing the bug. I'll try to have this fixed soon.

@AriX
Copy link
Author

AriX commented Jul 17, 2015

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants