Transmuting self to mut self is UB

[kpp]

nes-emulator/src/joystick.rs

Line 49 in 0b9e321

let mut_self:&mut Self = unsafe { transmute(self) };

nes-emulator/src/ppu.rs

Line 493 in 0b9e321

let ppu:&mut Ppu = unsafe { &mut *self.ppu };

nes-emulator/src/joystick.rs

Line 43 in 0b9e321

let mut_self:&mut Self = unsafe { transmute(self) };

nes-emulator/src/joystick.rs

Line 49 in 0b9e321

let mut_self:&mut Self = unsafe { transmute(self) };

[MichaelBurge]

Thanks for catching this. I've replaced these with a Cell in the Joystick struct

110fa57

That particular line in ppu.rs is okay, because CpuPpuInterconnect stores mutable pointers which that is turning into mutable references.

There is a related issue in that

nes-emulator/src/ppu.rs

Line 520 in 0b9e321

let cpu = unsafe { &mut *self.cpu };

allows two mutable references to a C6502 object to be live at the same time. But that is slightly different than what you have here.