Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #106

Closed
MichaelCurrin opened this issue May 12, 2021 · 4 comments · Fixed by #130
Closed

Add dark mode #106

MichaelCurrin opened this issue May 12, 2021 · 4 comments · Fixed by #130
Assignees
Labels
enhancement New feature or request

Comments

@MichaelCurrin
Copy link
Owner

From inspecting in Chrome / Nativefier:

Screen Shot 2021-05-12 at 9 26 41 am

Screen Shot 2021-05-12 at 9 26 44 am

@MichaelCurrin MichaelCurrin added the enhancement New feature or request label May 12, 2021
@minhhang107
Copy link
Contributor

I'd like to work on this one. Can you assign me?

@MichaelCurrin
Copy link
Owner Author

MichaelCurrin commented Nov 16, 2021

Sure!

I've not implemented a dark mode before and the screenshots of a mock are not accessible (poor contrast). So you can suggest a solution.

Maybe white text on a dark grey background will work and special attention for links, navbar, and codeblocks. I'd also be happy to keep the codeblocks light as in screenshot, as the work to change the highlight.js theme will be more complicated

And a toggle for dark mode. There was recent work to have a global store in store.ts if you want to persist darkMode=false there.

@MichaelCurrin
Copy link
Owner Author

MichaelCurrin commented Nov 16, 2021

For inspiration

@minhhang107
Copy link
Contributor

I'll probably use white text for dark mode. And you're right about the codeblock. I've been looking at it and can't find a solution to switch highlight.js theme yet so keeping the light background should be good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants