New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode #106
Comments
I'd like to work on this one. Can you assign me? |
Sure! I've not implemented a dark mode before and the screenshots of a mock are not accessible (poor contrast). So you can suggest a solution. Maybe white text on a dark grey background will work and special attention for links, navbar, and codeblocks. I'd also be happy to keep the codeblocks light as in screenshot, as the work to change the highlight.js theme will be more complicated And a toggle for dark mode. There was recent work to have a global store in store.ts if you want to persist |
For inspiration
|
I'll probably use white text for dark mode. And you're right about the codeblock. I've been looking at it and can't find a solution to switch highlight.js theme yet so keeping the light background should be good for now. |
From inspecting in Chrome / Nativefier:
The text was updated successfully, but these errors were encountered: