Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Instagram): Update Instagram oEmbed endpoint #148

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

MichaelDeBoey
Copy link
Owner

As announced on their developers blog, Facebook made changes to tokenless access for Instagram oEmbed endpoints.
This means we now have to pass an accessToken, which is an App Access Token (recommended) or Client Access Token.

BREAKING CHANGE: You'll now need to pass a required accessToken option whenever you're using the Instagram service. Check out the Instagram oEmbed access token docs and requirements to know how to get this.

Fixes #147

BREAKING CHANGE: You'll now need to pass a required `accessToken` option whenever you're using the Instagram service. Check out the Instagram oEmbed access token docs and requirements to know how to get this.
@MichaelDeBoey MichaelDeBoey added the ⚙️ Instagram Issue or pull request regarding Instagram label Oct 19, 2020
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          218       219    +1     
  Branches        28        28           
=========================================
+ Hits           218       219    +1     
Impacted Files Coverage Δ
src/transformers/Instagram.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e0a3e...410f12a. Read the comment docs.

Copy link
Sponsor Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@MichaelDeBoey MichaelDeBoey merged commit 2880ab1 into master Oct 20, 2020
@MichaelDeBoey MichaelDeBoey deleted the update-instagram-eombed-endpoint branch October 20, 2020 15:00
@MichaelDeBoey
Copy link
Owner Author

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump ⚙️ Instagram Issue or pull request regarding Instagram released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instagram returns 400 response about deprecated oEmbed endpoint
2 participants