Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: graceful kill for the bridge export and import functionalities #175

Closed
4 tasks
a-hilaly opened this issue Jul 5, 2019 · 1 comment · Fixed by #190
Closed
4 tasks

feat: graceful kill for the bridge export and import functionalities #175

a-hilaly opened this issue Jul 5, 2019 · 1 comment · Fixed by #190
Assignees
Labels
bridge bridge related issues Core Concerns the core of git-bug enhancement New feature or request

Comments

@a-hilaly
Copy link
Collaborator

a-hilaly commented Jul 5, 2019

for now interrupting git-bug while exporting or importing issues can damage local or remote and cause problems if when we re-execute these commands.
To avoid this we can implement a global context to gracefully shutdown these functions ! for this we need:

  • To use a global context for the bridge importer and exporter
  • use the context to cancel http requests
  • Add cancel functions to Interrupt handler
  • Commit operations before exiting the functions (SetMetadataOperation in the exporter for example `)

(this bug was created using the new exporter)

@MichaelMure
Copy link
Owner

(this bug was created using the new exporter)

🎉 🎉 🎉 🎉 🎉 🎉 🎉

great work !

@a-hilaly a-hilaly added Core Concerns the core of git-bug bridge bridge related issues labels Jul 6, 2019
@a-hilaly a-hilaly added the enhancement New feature or request label Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge bridge related issues Core Concerns the core of git-bug enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants