Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: Rendering Pokemon cards to DOM. #49

Closed
Tracked by #6
JoeDravarol opened this issue Jun 2, 2022 · 0 comments
Closed
Tracked by #6

REFACTOR: Rendering Pokemon cards to DOM. #49

JoeDravarol opened this issue Jun 2, 2022 · 0 comments
Assignees
@JoeDravarol
Labels
bug Something isn't working enhancement New feature or request frontend

Comments

@JoeDravarol
Copy link
Collaborator

JoeDravarol commented Jun 2, 2022 •
edited
Loading

Propose refactor:

  • Replace dummy data with data from backend.
  • Add helper function to render pokemon cards in the randomized order provided by response data.
  • Remove cards from HTML as it will be generated in the JavaScript.
  • Remove .dance CSS class to avoid visual bug.
@JoeDravarol JoeDravarol self-assigned this Jun 2, 2022
This was referenced Jun 2, 2022
Merged
Open
@JoeDravarol JoeDravarol added bug Something isn't working enhancement New feature or request frontend labels Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeDravarol JoeDravarol

Labels
bug Something isn't working enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoeDravarol