Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate copies of front-end code #54

Closed
Tracked by #6
MichaelPachec0 opened this issue Jun 5, 2022 · 1 comment · Fixed by #55
Closed
Tracked by #6

Duplicate copies of front-end code #54

MichaelPachec0 opened this issue Jun 5, 2022 · 1 comment · Fixed by #55
Labels
bug Something isn't working frontend help wanted Extra attention is needed question Further information is requested

Comments

@MichaelPachec0
Copy link
Owner

MichaelPachec0 commented Jun 5, 2022

So its come to my attention that #45 committed a copy of the front-end to the root folder. The back end code code wont serve this since it will only look at the files that are in the public folder and only in the public folder. Since there have been new commits to the front end, there is divergence. In this case the front end developers need to decide whether to keep and if so what to keep from what this pr merged.

@MichaelPachec0 MichaelPachec0 added bug Something isn't working help wanted Extra attention is needed question Further information is requested frontend labels Jun 5, 2022
@MichaelPachec0 MichaelPachec0 mentioned this issue Jun 5, 2022
13 tasks
@MichaelPachec0
Copy link
Owner Author

MichaelPachec0 commented Jun 5, 2022

  • Choice 1: revert and then ask for a reissue:
    i can revert this PR's code so that the repository is in a sane state. This would mean that there would have to be a reissue of the PR, with the front end code changes in the correct path's. The PR owner would have to carefully pick and choose which code should be committed since as i mentioned earlier, front end code has been merged.

  • Choice 2:
    Since the PR has already been committed, we can have the front end devs pick and choose code they would like to keep, send pr's and once front end devs are happy with the code in the public folder, delete the files.

Choice 1 will probably be the best way to do this. But ill leave to the front end to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend help wanted Extra attention is needed question Further information is requested
Projects
None yet
1 participant