Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files #16

Closed
wants to merge 8 commits into from
Closed

Conversation

mesquitaa
Copy link

updating files to follow Google implementation v8.10.5 of Feb 08, 2019.

Follow the Google Release Notes:
Feb 06, 2019: v8.10.5
Metadata changes:

  • Updated phone metadata for region code(s):
    AE, AG, AI, AM, AR, AS, AT, AU, AZ, BA, BB, BE, BG, BM, BO, BR, BS, BT, BW,
    BY, CG, CH, CL, CO, DE, DM, DZ, ES, FI, FR, GB, GD, GE, GR, GU, HN, HR, IE,
    IL, IN, IT, JM, JO, JP, KG, KN, KP, KR, KY, LC, LI, LK, LT, LU, MA, MC, MD,
    MG, MM, MP, MS, MU, MV, MW, MX, MY, NA, NC, NE, NF, NL, NO, NZ, PE, PH, PL,
    PY, RO, RU, SA, SB, SC, SE, SG, SI, SK, SM, SN, SO, SR, SX, TC, TJ, TM, TO,
    TR, TT, TZ, UG, UY, VC, VG, VI, VN, XK, ZM, ZW
  • Updated short number metadata for region code(s): BR, TH
  • Updated geocoding data for country calling code(s): 54 (en), 55 (en, pt)
  • Updated carrier data for country calling code(s): 55 (en)
  • Updated / refreshed time zone meta data.

Jan 24, 2019: v8.10.4
Metadata changes:

  • Updated phone metadata for region code(s):
    AR, AT, BH, BI, CL, CN, CW, CZ, DE, FI, FM, HK, KR, LA, LU, ML, NC, NE, PA,
    SB, TT, ZW
  • Updated short number metadata for region code(s): AR, KR
  • Updated geocoding data for country calling code(s): 54 (en, es), 686 (en)
  • Updated carrier data for country calling code(s):
    254 (en), 507 (en), 599 (en), 880 (en)

Jan 08, 2019: v8.10.3
Code changes:

  • Better documentation for getLengthOfNationalDestinationCode to emphasise that
    not every number has one.
  • Removed unused code in the AsYouTypeFormatter: We no longer have numbers in
    formatting matching patterns, only \d.
    Metadata changes:
  • Updated phone metadata for region code(s):
    EG, GM, HK, LR, MM, NG, SD, UZ, VN, VU
  • Updated geocoding data for country calling code(s): 249 (en)
  • Updated carrier data for country calling code(s):
    84 (en), 95 (en), 220 (en), 231 (en), 852 (en, zh, zh_Hant), 965 (ar)
  • Updated / refreshed time zone meta data.

Dec 06, 2018: v8.10.2
Metadata changes:

  • Updated phone metadata for region code(s):
    882, AE, AL, AR, BD, BR, CN, ID, IN, JM, LK, MG, MU, MX, OM, SI, UA, ZW
  • Updated short number metadata for region code(s): IN, MG, MX, SI
  • Updated geocoding data for country calling code(s): 52 (en, es), 261 (en)
  • Updated carrier data for country calling code(s):
    66 (en), 91 (en), 386 (en), 968 (en)
  • Updated / refreshed time zone meta data.

@mesquitaa
Copy link
Author

@MichaelRocks Could you check the new version? In this PR, I only updated implementations to following Google implementations.

@MichaelRocks
Copy link
Owner

But I've already merged all the changes from Google's libphonenumber including the last version 8.10.5. What exactly do you want me to merge additionally?

@mesquitaa
Copy link
Author

@MichaelRocks

I updated your classes implementations following google samples, the unique difference it's in PhoneNumberUtil.java, because it's necessary a context read one file in Android. Now it's simpler updated your library just getting all google files, keeping only the constructor in PhoneUtils.java.

In the future, I think it's possible to create an extension class allowing keep the PhoneNumberUtil.java the same that Google version, updating just one file of your library when it's is necessary.

Another thing that I think be necessary it changes the getIntance() accessor to protected avoiding that Android developers called this method.

@MichaelRocks
Copy link
Owner

I'll close this PR as it's too broad and contains conflicts. If you want to change something please consider creating a new PR with only necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants