List structure #1
Conversation
There was a problem hiding this comment.
Hi @Micky373,
Good job so far! 馃憦
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes 鈾伙笍
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/index.js
Outdated
| // import checkBoxing from './check_box.js' | ||
| // Populating the html element |
There was a problem hiding this comment.
- I would recommend removing the commented code to make the codebase cleaner.
src/styles.css
Outdated
|
|
||
| /* padding: 1rem 0; */ |
There was a problem hiding this comment.
- Same here. I would recommend removing the commented code to make the codebase cleaner.
README.md
Outdated
|
|
||
| **Instructions on setting up your project locally.** | ||
| The project could be accessed by visiting the website link. | ||
|
|
There was a problem hiding this comment.
- I would recommend adding all the steps to run the project locally. It should include How to clone, going to right folder, and running right command or opening right file to see the project.
There was a problem hiding this comment.
Hi @Micky373,
APPROVED 馃憤 馃
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 馃帀
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello Reviewer,
In this project I have done these tasks:
Thanks 馃榿