Add remove feature #2
Conversation
There was a problem hiding this comment.
馃煛 Status: Changes Required 馃洃
Hi @Micky373 馃憢馃徎,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight 馃憦馃徎
鉁旓笍 No linter errors.
鉁旓笍 You used correct Github Flow.
鉁旓笍 Professional README.
鉁旓笍 Used webpack to bundle JavaScript.
鉁旓笍 Implemented adding a new task
鉁旓笍 Implemented editing task descriptions
鉁旓笍 Implemented deleting a task
鉁旓笍 Removed hard-coded items from the tasks array
鉁旓笍 Used local storage to store To-Do List changes
Required Changes 鈾伙笍
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/index.js
Outdated
| const addTask = () => { | ||
| const activity = document.querySelector('#add_task').value; | ||
| if (activity !== null) { | ||
| const tasks = new Task(activity, false, ((taskLists.length) + 1)); | ||
| taskLists.push(tasks); | ||
| showActivity([tasks]); | ||
| addToLocalStorage(taskLists); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
Hello @Micky373, It is a good job you are doing here 馃挭馃徎! Your project looks amazing 鉂わ笍 - I like the font you used and the red trash icons to be exact. Every thing looks great,
- I will just request you to use a new JavaScript file for the new functionality (add, edit, delete) that was introduced as required in this milestone
There was a problem hiding this comment.
Hi @Micky373,
Great work on making the changes requested by a previous reviewer 馃憦
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Required Changes 鈾伙笍
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
|
||
| const taskLists = JSON.parse(localStorage.getItem('data')); | ||
|
|
||
| const addTask = () => { |
There was a problem hiding this comment.
- Great job implementing the changes requested by the previous reviewer. But, I think the changes you have made caused more issues. For example, when I tried to add a task it did not work properly. Below you can see the screenshot please fix the issue then request another review.
There was a problem hiding this comment.
Hello @Micky373, I'm your new reviewer.
In this new commit, it is now possible to add tasks, but it is impossible to delete them because the delete buttons are not generated now, and therefore, missing. I can confirm this was not happening before the original review.
I can help. I'll be waiting on slack for the next 30 minutes, otherwise, I'll have to request changes.
I already contacted you on Slack, please respond. It's now 6:54 am for me.
Note: The student responded on Slack, we are working out the issue.
There was a problem hiding this comment.
Hi @Micky373,
Wow, you did it 馃帀
Thank you for answering on Slack, and for explaining to me that you need to click on a task in order for the delete button to appear, just like in the template video. 馃挭 馃 銑楋笍
The changes requested by the previous reviewer have been implemented, therefore, I'm approving the pr.
Well done!
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 馃帀
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello Reviewer,
In this milestone I have done:
Thank you 馃榿